-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pnpm #348
base: master
Are you sure you want to change the base?
Switch to pnpm #348
Changes from all commits
2f1d15a
55d9200
657202d
9e32d1c
32f13f2
8155c84
fb1eed6
06ace34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: Setup node and pnpm | ||
description: Setup node and install dependencies using pnpm | ||
runs: | ||
using: "composite" | ||
steps: | ||
- uses: volta-cli/action@v1 | ||
# minimum supported Node | ||
with: | ||
node-version: 14.x | ||
- name: Cache pnpm modules | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~/.pnpm-store | ||
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}-pnpm- | ||
- uses: pnpm/[email protected] | ||
with: | ||
version: 7.5.2 | ||
run_install: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ | |
"test:ember": "ember test", | ||
"test:ember-compatibility": "ember try:each", | ||
"test-typings": "node node_modules/typescript/bin/tsc", | ||
"prepack": "yarn babel --extensions '.ts' --presets @babel/preset-typescript addon --out-dir addon/ --ignore '**/*.d.ts'", | ||
"prepack": "pnpm babel --extensions '.ts' --presets @babel/preset-typescript addon --out-dir addon/ --ignore '**/*.d.ts'", | ||
"postpack": "rimraf addon/**/*.js", | ||
"postpublish": "npm-run-all clean" | ||
}, | ||
|
@@ -36,6 +36,7 @@ | |
}, | ||
"devDependencies": { | ||
"@babel/cli": "^7.17.6", | ||
"@babel/core": "^7.18.9", | ||
NullVoxPopuli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"@babel/preset-typescript": "^7.16.0", | ||
"@ember/optional-features": "^2.0.0", | ||
"@ember/test-helpers": "^2.6.0", | ||
|
@@ -69,7 +70,7 @@ | |
"ember-source": "~3.28.6", | ||
"ember-source-channel-url": "^3.0.0", | ||
"ember-template-lint": "^3.12.0", | ||
"ember-try": "^1.4.0", | ||
"ember-try": "^2.0.0", | ||
"eslint": "^7.32.0", | ||
"eslint-config-prettier": "^8.3.0", | ||
"eslint-plugin-ember": "^10.5.7", | ||
|
@@ -88,7 +89,7 @@ | |
"webpack": "^5" | ||
}, | ||
"engines": { | ||
"node": "12.* || 14.* || >= 16" | ||
"node": ">= 16" | ||
}, | ||
"publishConfig": { | ||
"registry": "https://registry.npmjs.org" | ||
|
@@ -117,8 +118,16 @@ | |
"publish": false | ||
} | ||
}, | ||
"pnpm": { | ||
"overrides": { | ||
"@octokit/core": "^4.0.0" | ||
}, | ||
"overrides-notes": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is super nice. Is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It ignores unknown keys - would be cool if this were standardized or something 🤔 |
||
"@octokit/core": "release-it -> @octokit/rest -> @octokit/plugin-paginate-rest wants @octokit/core v4, but found 3.6. The problem is that release-it-lerna-changelog + release-it have incompatible peers. This 'fix' relies on the accident that @octokit/core happens to work with all the other deps" | ||
} | ||
}, | ||
"volta": { | ||
"node": "12.22.3", | ||
"yarn": "1.22.11" | ||
"node": "16.20.0", | ||
"pnpm": "8.1.1" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to flag up: this is breaking! That's fine as long as it's intentional. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is!
node 12 is EOL'd, and pnpm doesn't support it