Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow release-date and release-versions to be null #5

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

mansona
Copy link
Member

@mansona mansona commented Aug 9, 2022

This allows empty release-dates and release-versions (which we can change when we have finished backfilling) and then once they are specified it will enforce the type 👍

i.e. this is how you implement "allows null". The "required" and "allowEmpty" are both quite buggy in revalidator so we have to do it a different way 👍

@kategengler
Copy link
Member

Could you please open an issue here to restore it once they are in place?

I originally had the CI in emberjs/rfcs only fully linting changed files so that we could have the "real" rules for RFCs going through the process.

@mansona
Copy link
Member Author

mansona commented Aug 9, 2022

Done #6

Yes, I had to remove that past implementation because now that the RFCs need to be machine readable the all need to be equally machine readable. This will allow us to prevent the regression that happened when @wagenet added FIXME in places that should have been dates 👍

@mansona mansona deleted the allow-empty branch August 9, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants