Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter how threshold works for disabling the SDK #1689

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Alters how the SDK calculates whether it should be disabled by checking the last 6 digits of the device ID. This matches the behavior with iOS & allows for more granular control of behavior.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner November 18, 2024 13:01
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.18%. Comparing base (7cb79ce) to head (8843f8d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
- Coverage   84.18%   84.18%   -0.01%     
==========================================
  Files         456      456              
  Lines       10637    10635       -2     
  Branches     1605     1605              
==========================================
- Hits         8955     8953       -2     
  Misses        945      945              
  Partials      737      737              
Files with missing lines Coverage Δ
...internal/config/behavior/BehaviorThresholdCheck.kt 100.00% <100.00%> (ø)
...dk/internal/config/behavior/SdkModeBehaviorImpl.kt 80.00% <ø> (ø)
---- 🚨 Try these New Features:

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 848ef70 into main Nov 19, 2024
7 checks passed
@fractalwrench fractalwrench deleted the update-disable-flag branch November 19, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants