Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AEI capture code quality #1694

Merged
merged 1 commit into from
Nov 21, 2024

refactor: improve aei code quality

b830c76
Select commit
Loading
Failed to load commit list.
Merged

Improve AEI capture code quality #1694

refactor: improve aei code quality
b830c76
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 1s

84.32% (-0.01%) compared to e855169

View this Pull Request on Codecov

84.32% (-0.01%) compared to e855169

Details

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (e855169) to head (b830c76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sdk/internal/capture/aei/ApplicationExitInfoExt.kt 86.66% 0 Missing and 4 partials ⚠️
...embracesdk/internal/injection/FeatureModuleImpl.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
- Coverage   84.33%   84.32%   -0.01%     
==========================================
  Files         458      459       +1     
  Lines       10683    10646      -37     
  Branches     1604     1597       -7     
==========================================
- Hits         9009     8977      -32     
+ Misses        945      941       -4     
+ Partials      729      728       -1
Files with missing lines Coverage Δ
...acesdk/internal/prefs/EmbracePreferencesService.kt 93.85% <100.00%> (ø)
...bracesdk/internal/capture/aei/AeiDataSourceImpl.kt 100.00% <100.00%> (+10.63%) ⬆️
...oid/embracesdk/internal/capture/aei/TraceResult.kt 100.00% <100.00%> (ø)
...embracesdk/internal/injection/FeatureModuleImpl.kt 99.19% <66.66%> (-0.81%) ⬇️
...sdk/internal/capture/aei/ApplicationExitInfoExt.kt 86.66% <86.66%> (ø)
---- 🚨 Try these New Features:
View more details on Codecov