Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unityCrashId, as we don't use it anymore #1702

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Nov 20, 2024

  • The backend isn't considering any case where NDK and JVM crashes have the same ID. It might even bring issues.
  • We weren't setting the ID correctly. If installSignalHandlers gets posted to the main thread handler before we set the ID, we will always use different IDs.
  • I tested crashes on an armeabi-v7a device, and we only get native crashes. The CrashDataSource handler never gets called.

@priettt priettt requested a review from a team as a code owner November 20, 2024 18:34
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@priettt priettt force-pushed the priettt/removeUnityCrashId branch 2 times, most recently from f8d8a0f to 780d981 Compare November 20, 2024 19:03
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (9b81dfb) to head (74ff4b1).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
- Coverage   84.18%   84.17%   -0.01%     
==========================================
  Files         457      457              
  Lines       10684    10676       -8     
  Branches     1609     1606       -3     
==========================================
- Hits         8994     8987       -7     
  Misses        957      957              
+ Partials      733      732       -1     
Files with missing lines Coverage Δ
...esdk/internal/capture/crash/CrashDataSourceImpl.kt 92.75% <100.00%> (-0.11%) ⬇️
...d/embracesdk/internal/injection/CrashModuleImpl.kt 100.00% <ø> (ø)
...bracesdk/internal/injection/CrashModuleSupplier.kt 100.00% <ø> (ø)
...droid/embracesdk/internal/ndk/EmbraceNdkService.kt 61.78% <100.00%> (-0.10%) ⬇️
...cesdk/internal/injection/ModuleInitBootstrapper.kt 88.52% <ø> (-0.04%) ⬇️
---- 🚨 Try these New Features:

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priettt priettt merged commit 341006b into main Nov 21, 2024
7 checks passed
@priettt priettt deleted the priettt/removeUnityCrashId branch November 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants