Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug tracing to scheduling service #1735

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Enhance the delivery tracing by adding some extra events in the SchedulingService. If an integration test fails now it should give us a decent idea of what's going wrong.

@fractalwrench fractalwrench requested a review from a team as a code owner November 29, 2024 12:55
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (a0cd7e9) to head (fabb99f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...esdk/internal/delivery/debug/DeliveryTraceState.kt 53.33% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   85.19%   85.20%           
=======================================
  Files         459      459           
  Lines       10447    10474   +27     
  Branches     1567     1572    +5     
=======================================
+ Hits         8900     8924   +24     
- Misses        840      843    +3     
  Partials      707      707           
Files with missing lines Coverage Δ
...mbracesdk/internal/injection/DeliveryModuleImpl.kt 76.92% <100.00%> (+0.22%) ⬆️
...bracesdk/internal/delivery/debug/DeliveryTracer.kt 80.95% <100.00%> (+4.48%) ⬆️
...esdk/internal/delivery/intake/IntakeServiceImpl.kt 100.00% <100.00%> (ø)
...ernal/delivery/scheduling/SchedulingServiceImpl.kt 87.80% <100.00%> (+0.96%) ⬆️
...esdk/internal/delivery/debug/DeliveryTraceState.kt 53.48% <53.33%> (+3.48%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit adb5a46 into main Nov 29, 2024
7 checks passed
@fractalwrench fractalwrench deleted the enhance-delivery-tracing branch November 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants