Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash "cannot form weak reference to instance of viewcontroller" #159

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ArielDemarco
Copy link
Collaborator

@ArielDemarco ArielDemarco commented Jan 17, 2025

Overview

There's a crash happening lately

Cannot form weak reference to instance (xxxxxxxx) of class AController. It is possible that this object was over-released, or is in the process of deallocation.
Seems to happen mostly on SwiftUI views (in particular, short-lived UIHostingControllers and the ones from the navigation/presentation stack).

To prevent this, we got rid of every mention/usage of UIViewController in background threads to avoid race conditions.

Copy link

github-actions bot commented Jan 17, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@ArielDemarco ArielDemarco marked this pull request as ready for review January 17, 2025 16:57
@ArielDemarco ArielDemarco requested a review from a team as a code owner January 17, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant