-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose macros config in babel #2249
base: main
Are you sure you want to change the base?
Conversation
Notes from discussion at office hours:
|
I think in order to do that we need to have the classic macros config, in ember-cli-build.js, load the babel config. It's too intense to re-apply the options post-macros-creation. |
err no, it'd just be the same problem, but in reverse |
be7de2c
to
b628891
Compare
Update: I removed the changes to |
"exports": { | ||
".": "./src/index.js", | ||
"./babel": "./src/babel.js", | ||
"./src/*": "./src/*.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want people to import everything from src
? Or is this for backwards compatibility, because people were doing so before?
@embroider/macros were not configurable in main/vite before this change.
Proposed way of configuring macros is similar to how we've been doing so in ember-cli-build.js
removed from this PR
If we do end up needing this in the future,
we should have compat-macros output their combined options to compat-app-builder -> addBabelCompat
rather than the output,
and then have the babel plugin from compat read that in and it could then merge the options.
For example, in the babel config:
However, this doesn't solve the problem of configuring macros for the minimal app over in #2205
For the minimal app blueprint, we'd have folks do this in their babel config:
which.... could be better...
So.... I've done added to macros to allow for:
Which should be nice for the minimal blueprint in #2205