fix failure on first-run and auto-apply package.json updates #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2264 (comment) and also addresses automatically adding `exports` to package.json, since they're both in the same function. The problem with first-run failures was that Resolver expects to get constructed after any prebuilding is done. We were constructing it in ensureAppSetup before the prebuild.
Merged
void-mAlex
reviewed
Feb 18, 2025
| './tests/*': './tests/*', | ||
| './*': './app/*', | ||
| }; | ||
| writeFileSync(filename, JSON.stringify(json, null, 2)); |
There was a problem hiding this comment.
this is touching files I would never expect a codemod to touch and messing with my indentation at the same time
| try { | ||
| pkg = resolverLoader.resolver.packageCache.get(process.cwd()); | ||
| content = readFileSync(filename, 'utf8'); |
There was a problem hiding this comment.
this no longer serves the purpose of ensuring an ember app
I had fun digging into what it was actually doing because it was buried very deep inside resolver code but it actually ensures ember-source is in package json which may not be the case for a v2 addon but I wonder if that was the intention here
There was a problem hiding this comment.
That sounds like a good case to add to the test suite. I'm assuming we want to encourage people to be able to use this to update a v2 addon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2264 (comment) and also addresses automatically adding
exportsto package.json, since they're both in the same function.The problem with first-run failures was that Resolver expects to get constructed after any prebuilding is done. We were constructing it in ensureAppSetup before the prebuild.
This class of bug is harder to see now that prebuilds are optional. ResolverLoader will happily construct a Resolver with no prebuilt output present. But the resulting Resolver won't know anything about any v1 addons that were present.