Merge pull request #48 from emchooo/analysis-J2xb2a

Apply fixes from StyleCI
emchooo · Aug 7, 2020 · 12a7e8b · 12a7e8b
2 parents aa1469f + 536bd88
commit 12a7e8b
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 12 deletions.
diff --git a/app/Console/Commands/MailnessInstallCommand.php b/app/Console/Commands/MailnessInstallCommand.php
@@ -31,10 +31,10 @@ public function handle()
 
         $this->createEnvFile();
 
-        if (strlen(config('app.key')) === 0) :
+        if (strlen(config('app.key')) === 0) {
             $this->call('key:generate');
-        $this->line('Secret key properly generated');
-        endif;
+            $this->line('Secret key properly generated');
+        }
 
         $credentials = $this->requestDatabaseCredentials();
 

diff --git a/app/Jobs/SendCampaign.php b/app/Jobs/SendCampaign.php
@@ -6,13 +6,11 @@
 use App\Models\Lists;
 use App\Models\SendingLog;
 use App\Models\Service;
-use DOMDocument;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
-use Illuminate\Support\Str;
 
 class SendCampaign implements ShouldQueue
 {
@@ -52,5 +50,4 @@ public function handle()
 
         SetCampaignAsSent::dispatch($this->campaign);
     }
-
 }
diff --git a/app/Jobs/SendEmail.php b/app/Jobs/SendEmail.php
@@ -5,7 +5,6 @@
 use App\Jobs\Middleware\RateLimited;
 use App\Mail\CampaignMail;
 use App\Models\SendingLog;
-use DOMDocument;
 use Exception;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;

diff --git a/app/Mail/CampaignMail.php b/app/Mail/CampaignMail.php
@@ -2,10 +2,10 @@
 
 namespace App\Mail;
 
+use App\Models\SendingLog;
 use Illuminate\Bus\Queueable;
 use Illuminate\Mail\Mailable;
 use Illuminate\Queue\SerializesModels;
-use App\Models\SendingLog;
 
 class CampaignMail extends Mailable
 {
@@ -36,12 +36,11 @@ public function __construct(SendingLog $send, $config)
      */
     public function build()
     {
-
         return $this->html($this->getMailContent());
     }
 
-    protected function getMailContent() {
+    protected function getMailContent()
+    {
         return $this->send->campaign->html_formated;
     }
-
 }
diff --git a/app/Rules/EmailUniqueForEachListRule.php b/app/Rules/EmailUniqueForEachListRule.php
@@ -40,7 +40,7 @@ public function passes($attribute, $value)
 
         return null === Contact::query()
                                 ->where('email', $value)
-                                ->when($this->list, function (Builder $query) use ($contact) {
+                                ->when($this->list, function (Builder $query) {
                                     return $query->where('list_id', '=', $this->list->id);
                                 })
                                 ->when($contact, function (Builder $query) use ($contact) {