Make objective classes slotted

emdgroup · Aug 3, 2024 · 0d2e7e8 · 0d2e7e8
1 parent 6feb950
commit 0d2e7e8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 ### Fixed
-- Parameter classes are now slotted due to `cached_property` attrs support
+- Parameter and objective classes are now slotted due to `cached_property` attrs support
 
 ## [0.10.0] - 2024-08-02
 ### Breaking Changes

diff --git a/baybe/objectives/base.py b/baybe/objectives/base.py
@@ -14,11 +14,8 @@
 from baybe.serialization.mixin import SerialMixin
 from baybe.targets.base import Target
 
-# TODO: Reactive slots in all classes once cached_property is supported:
-#   https://github.com/python-attrs/attrs/issues/164
 
-
-@define(frozen=True, slots=False)
+@define(frozen=True)
 class Objective(ABC, SerialMixin):
     """Abstract base class for all objectives."""
 

diff --git a/baybe/objectives/desirability.py b/baybe/objectives/desirability.py
@@ -61,7 +61,7 @@ def scalarize(
     return func(values, weights=weights)
 
 
-@define(frozen=True, slots=False)
+@define(frozen=True)
 class DesirabilityObjective(Objective):
     """An objective scalarizing multiple targets using desirability values."""
 

diff --git a/baybe/objectives/single.py b/baybe/objectives/single.py
@@ -8,7 +8,7 @@
 from baybe.targets.base import Target
 
 
-@define(frozen=True, slots=False)
+@define(frozen=True)
 class SingleTargetObjective(Objective):
     """An objective focusing on a single target."""