add on-long-touch option #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayleaf
commented
Aug 24, 2024
emersion
reviewed
Feb 6, 2025
| @@ -144,7 +158,7 @@ static void touch_handle_up(void *data, struct wl_touch *wl_touch, | |||
| wl_list_for_each(notif, &state->notifications, link) { | |||
| if (hotspot_at(¬if->hotspot, seat->touch.pts[id].x, seat->touch.pts[id].y)) { | |||
| struct mako_surface *surface = notif->surface; | |||
| notification_handle_touch(notif, &ctx); | |||
| notification_handle_touch(notif, &ctx, time - seat->touch.pts[id].time); | |||
There was a problem hiding this comment.
If we already have a timer, I don't think we need to also handle the timeout here?
emersion
reviewed
Feb 6, 2025
Comment on lines
+71
to
+75
| *long-press-duration*=_time_ | ||
| Specifies the cutoff time (in milliseconds) for a press to be | ||
| considered a long press. | ||
|
|
||
| Default: 500 |
There was a problem hiding this comment.
I'd prefer not to expose a config option for this for now. We can always add in the future if needed, but if there's no clear use-case for it, I prefer not to add something which might tie our hands later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are much less input options when using a touchscreen, so hopefully this should somewhat bridge the gap in experience.