Add pointer events and focus handling for apps run in a Shadow DOM #5627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5627-shadow-dom-events-focus |
emilk
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks good to me, but I'd love it if @jprochazk could take a quick look too
jprochazk
approved these changes
Jan 23, 2025
… shadow-dom-events-focus
… shadow-dom-events-focus
… shadow-dom-events-focus
lucasmerlin
added
web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles pointer events and focus which did following changes:
element_from_pointand focus is now acquired from root node object by usingget_root_nodefrom document or a shadow root.TextAgentis appended individually in each shadow root.These changes handles pointer events and focus well in a web app that are running in a shadow dom, or else the hover pointer actions and keyboard input events are not triggered in a shadow dom.
Helpful for building embeddable/multi-view web-apps.