Android Marshmallow, continuos record, ios documents #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brary/NoCloud. This is for 2 reasons:
1) as recommended by Apple, the Documents folder is used to store user generated content.
2) [recorder prepareToRecord] fails because the Library/NoCloud directory does not exist by default
…cording (by not creating the countdown timer, and either not specifying the seconds, or doing -1)
|
Hi Michael (@emj365) Is it possible to merge this in? 谢谢 |
…os (to be more consistent and match what is needed for voice recordings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On newer versions of android and iOS your plugin does not work.
This fixes:
And additionally, I made it so you don't have to specify a duration. That seems useless to me in most cases, I just want to record continuously. (Though obviously, if you specify a duration, it will work still as before)