fix(BaseKeyboardNavigation): navigation with Shadow DOM enabled #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issues with the
BaseKeyboardNavigationcomponent when the Shadow DOM is enabled. The following changes have been made to ensure seamless keyboard navigation and event handling within Shadow DOM boundaries.Type of change
What is the destination branch of this PR?
MainHow has this been tested?
These changes should be tested along with
x-archetypewith Shadow DOM enabled. You can check that the predictive layer in the empathize component is now reachable with the keyboard. An additional unit test for retrieving the active element as added.Tests performed according to testing guidelines: