Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x-installer): update to vue3 and adapt x-installer #1572

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

victorcg88
Copy link
Contributor

@victorcg88 victorcg88 commented Jul 22, 2024

Pull request template

On this PR we update to Vue 3. Also updating the related packages. These are the minimum changes required to run the x-component-demo app on the browser.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality not to work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify: vue3-update-rc

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@victorcg88 victorcg88 requested a review from a team as a code owner July 22, 2024 14:28
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How nice to see things are finally starting to take shape!

@victorcg88 victorcg88 force-pushed the x-installer-migration branch from f1fb2ee to 9b5519d Compare July 23, 2024 14:31
@joseacabaneros joseacabaneros merged commit c6b28e5 into vue3-update-rc Jul 23, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants