Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RelatedPrompt): component logic to be reusable #1696

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

AdrianArenal
Copy link
Contributor

@AdrianArenal AdrianArenal commented Jan 20, 2025

RelatedPromptsTagList component test needs to be fixed in the future

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@AdrianArenal AdrianArenal force-pushed the refactor/related-prompts-components branch from b3ab608 to b8e20e7 Compare January 21, 2025 11:23
@AdrianArenal AdrianArenal force-pushed the refactor/related-prompts-components branch from a5139f0 to ad6476c Compare January 28, 2025 11:26
@AdrianArenal AdrianArenal marked this pull request as ready for review January 28, 2025 14:06
@AdrianArenal AdrianArenal requested a review from a team as a code owner January 28, 2025 14:06
@C4rlos99 C4rlos99 force-pushed the refactor/related-prompts-components branch from e4bc84c to fc86e95 Compare January 28, 2025 14:10
@C4rlos99 C4rlos99 force-pushed the refactor/related-prompts-components branch from de073bb to 14e4c1e Compare January 28, 2025 14:13
@AdrianArenal AdrianArenal force-pushed the refactor/related-prompts-components branch from d4eeeae to c278dc6 Compare January 28, 2025 14:37
@C4rlos99 C4rlos99 force-pushed the refactor/related-prompts-components branch from 11dbcba to 38fc7bd Compare January 29, 2025 08:32
@C4rlos99 C4rlos99 changed the title refactor(RelatedPrompt): component logic to be reusable (WIP) refactor(RelatedPrompt): component logic to be reusable Jan 29, 2025
@C4rlos99 C4rlos99 changed the title (WIP) refactor(RelatedPrompt): component logic to be reusable refactor(RelatedPrompt): component logic to be reusable Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants