fix(extra-params): give more priority to values prop over params state in the ExtraParamsProvided payload #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in the ExtraParamsProvided payload
AdrianArenal
previously approved these changes
Jan 28, 2025
| import ExtraParams from '../extra-params.vue'; | ||
| import { useState } from '../../../../composables/index'; |
There was a problem hiding this comment.
Suggested change
| import { useState } from '../../../../composables/index'; | |
| import { useState } from '../../../../composables'; |
diegopf
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
This PR gives more priority to the
valuesprop overparamsstate in theExtraParamsProvidedpayloadMotivation and context
MotiveMarket renders the
ExtraParamscomponent with each area changing, passing a newvaluesprop each time. The store state has alreadyparamsof the previousarea, so emitsExtraParamsProvidedXEvent with oldareabecause in the merge,paramsfrom the state has more priority.Type of change
What is the destination branch of this PR?
Main