Split the pthread library out of libc. NFC #22735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
pthread_library
branch
2 times, most recently
from
ef291c2
to
09f48a0
Compare
kripken
approved these changes
Oct 15, 2024
| @@ -5995,9 +5995,9 @@ def test_bad_lookup(self): | |||
| # partial list, but ok since we grab them as needed | |||
| 'parial': [{'EMCC_FORCE_STDLIBS': 'libc++'}, False], | |||
| # fail! not enough stdlibs | |||
| 'partial_only': [{'EMCC_FORCE_STDLIBS': 'libc++,libc,libc++abi', 'EMCC_ONLY_FORCED_STDLIBS': '1'}, True], | |||
| 'partial_only': [{'EMCC_FORCE_STDLIBS': 'libc++,libc,libpthread,libc++abi', 'EMCC_ONLY_FORCED_STDLIBS': '1'}, True], | |||
There was a problem hiding this comment.
Worth a changelog mention because this is observable by some users.
|
This change still needs some work. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 15, 2024
Instead we can use TLS which works for both single and multithreaded builds and also works with wasm workers. This is also needed for emscripten-core#22735
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 15, 2024
Instead we can use TLS which works for both single and multithreaded builds and also works with wasm workers. This is also needed for emscripten-core#22735
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 15, 2024
Instead we can use TLS which works for both single and multithreaded builds and also works with wasm workers. This is also needed for emscripten-core#22735
sbc100
force-pushed
the
pthread_library
branch
2 times, most recently
from
c46a95c
to
086be0b
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 15, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 15, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
force-pushed
the
pthread_library
branch
2 times, most recently
from
afb65ba
to
4f9aa81
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
The MTLibrary subclass is designed for libraries that build in all different modes. I think the wasm_workers library and the plans pthreads library should not be inheriting from this class. This is needed for both emscripten-core#22683 and emscripten-core#22735.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
The MTLibrary subclass is designed for libraries that build in all different modes. I think the wasm_workers library and the plans pthreads library should not be inheriting from this class. This is needed for both emscripten-core#22683 and emscripten-core#22735.
sbc100
added a commit
that referenced
this pull request
Oct 16, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
force-pushed
the
pthread_library
branch
from
4f9aa81
to
c4fef4b
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 16, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See emscripten-core#22735.
sbc100
force-pushed
the
pthread_library
branch
from
c4fef4b
to
3c06c7c
Compare
sbc100
added a commit
that referenced
this pull request
Oct 16, 2024
Previously the wasm workers build of `__errno_location` was using the single threaded code path which doesn't use a thead local location. In addition this change avoids the use of `__EMSCRIPTEN_PTHREADS__` in `__errno_location.c` which is helpful for unifying the shared memory libc build. See #22735.
sbc100
force-pushed
the
pthread_library
branch
from
3c06c7c
to
54151f7
Compare
sbc100
force-pushed
the
pthread_library
branch
2 times, most recently
from
a8d7355
to
b4da8b0
Compare
sbc100
force-pushed
the
pthread_library
branch
from
b4da8b0
to
21a6f1f
Compare
sbc100
force-pushed
the
pthread_library
branch
from
21a6f1f
to
023eb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that, as a followup we could then collapse libc-mt and libc-ww into a single libc-mt that didn't have any specific pthread stuff in it.