Use normal unquoted names in wasm worker messages. NFC #24232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
approved these changes
May 1, 2025
kripken
reviewed
May 1, 2025
src/lib/libwasm_worker.js
Outdated
| ___set_stack_limits(m['sb'] + m['sz'], m['sb']); | ||
| // region between wwParams.stackLowAddress and wwParams.stackSize, so we | ||
| // need to fix up the call below. | ||
| ___set_stack_limits(wwParams.stackLowAddress + wwParams.stackSize, wwParams.stackLowestAddress); |
There was a problem hiding this comment.
Above we have stackLowestAddress and here stackLowAddress - ?
There was a problem hiding this comment.
I guess that explains why the tests didn't pass :)
Now that the wasm worker code is always in the same file as the main JS code there is no need to quote or minify these names. See emscripten-core#24163.
kripken
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the wasm worker code is always in the same file as the main JS code there is no need to quote or minify these names. See #24163.