Skip to content

Fix typo in libdylink.js #24233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix typo in libdylink.js #24233

wants to merge 5 commits into from
+23 −10

Conversation

ryanking13
Copy link
Contributor

Fixes a minor typo. This code block is only used when -sDYLINK_DEBUG is passed.

sbc100
sbc100 approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we don't run any of the dylink tests with DYLINK_DEBUG? Can we add it at least one of them?

@ryanking13
Copy link
Contributor Author

Does that mean we don't run any of the dylink tests with DYLINK_DEBUG? Can we add it at least one of them?

I think so. I added -sDYLINK_DEBUG flag to some existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanking13 @sbc100