Fix flaky browser.test_sdl_mouse in Chrome. #24237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
May 1, 2025
sbc100
approved these changes
May 1, 2025
|
Looks like some kind of circleci infra failure? Maybe have to restart test run from the beggining? |
In small windows the spinner, progress bar, and status text shift around causing the canvas below them to be at a different location from when the test starts. I've filed emscripten-core#24236 about better ways to fix this. For now, this seems like the smallest change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In small windows the spinner, progress bar, and status text shift around causing the canvas below them to be at a different location from when the test starts.
I've filed #24236 about better ways to fix this. For now, this seems like the smallest change.