Add cairo as dependency for harfbuzz #1350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anutosh491
force-pushed
the
add_cairo_to_harfbuzz
branch
from
5a38591 to
ff2a2bd
Compare
anutosh491
force-pushed
the
add_cairo_to_harfbuzz
branch
from
ff2a2bd to
cb6f2d1
Compare
`cairo` v1.18.0 is the min version available on emscripten-forge
anutosh491
force-pushed
the
add_cairo_to_harfbuzz
branch
from
ef484b3 to
b38e436
Compare
|
@anutosh491 is this still relevant or can this be closed? |
|
Arghh I was trying to help @IsabelParedes out here with the recipe (I completely forgot if I was successful 😅 ) Maybe Isabel can tell us if something is pending here. |
| # TODO: test hb-view, hb-shape, and hb-subset with cairo or chafa enabled | ||
| - test -f $PREFIX/include/harfbuzz/hb-shape.h | ||
| - test -f $PREFIX/include/harfbuzz/hb-subset.h | ||
| # TODO: test hb-view with chafa enabled |
There was a problem hiding this comment.
This TODO should probably be addressed or removed. Other than that, LGTM
IsabelParedes
requested changes
Apr 15, 2025
|
|
||
| requirements: | ||
| build: | ||
| # NOTE: harfbuzz doesn't need host dependencies |
There was a problem hiding this comment.
We should be using the headers from the host platform and not the ones from build, in case these have been patched (for example in glib). These dependencies should also be listed under host to ensure they are available for the correct platform. glib has not be repackaged with the new emscripten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.