-
Notifications
You must be signed in to change notification settings - Fork 2
Fix "No memory" error and freezing a browser tab #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix "No memory" error and freezing a browser tab #46
Conversation
Maybe some ideas for handling larger archives, I had these already two weeks before, but they were not necessary. Of course, you could put it into a ReadableStream, as this is how webstreams work. |
Dear @martenrichter thank you for your ideas! |
This PR has solutions for #43 and #45
Freezing a browser tab happened when decompressed data could be large. For example, when compressed file has 10MB, but decompressed data has 98MB.
Since real decompressed data size is not known, as the solution is to take a average compressed ratio according to the example of compressed file of 10 MB and realize inital memory for (size of compressed file * compressed ratio)MB. Drawback is that the more decompressed data is the slower archive_read_data method is itself.
