-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core update 2108 #2318
base: dev
Are you sure you want to change the base?
Core update 2108 #2318
Conversation
platformio.ini
Outdated
@@ -120,6 +145,7 @@ board = lolin_s3 | |||
board_build.f_cpu = 240000000L | |||
board_upload.flash_size = 16MB | |||
board_build.partitions = esp32_partition_16M.csv | |||
board_build.extra_flags = -DBOARD_HAS_PSRAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again this overwrites the extra_flags with USB settings, lolinS3 has psram, no need to set it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this target just builds the binary, none of the USB settings are needed. eventually I'm going to remove the 'lolin_s3' and replace it with a generic 'esp32' for all boards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had this before, the serial console on S3 is not working if the USB extra flags are not set. This board profile already has PSRAM set, so this entry is bad, it does not affect PSRAM, but clears all other flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I remember, but I can't reproduce when testing on two different S3s. Wait until I've modified the board's and try again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember you have a S3 with 2 USB, one native and one with usb/serial chip. The native does not work with serial console if you modify the extra-flags.
Settings in the board file for lolin-s3:
"extra_flags": [
"-DARDUINO_LOLIN_S3",
"-DBOARD_HAS_PSRAM",
"-DARDUINO_USB_MODE=1",
"-DARDUINO_USB_CDC_ON_BOOT=1",
"-DARDUINO_RUNNING_CORE=1",
"-DARDUINO_EVENT_RUNNING_CORE=1"
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flash size is increased a lot, 4M partition does not fit anymore.
RAM: [== ] 15.1% (used 49412 bytes from 327680 bytes)
*** [checkprogsize] Explicit exit, status 1
Flash: [==========] 102.9% (used 2090133 bytes from 2031616 bytes)
Don't know what is the cause, i guess the Cpp17.
it was the |
Looks like a lot of changes, but its really just minor refactor