Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design tokens for Gallery component #153

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Design tokens for Gallery component #153

wants to merge 7 commits into from

Conversation

mariannuar
Copy link
Collaborator

Summary

Design tokens for the new Gallery component

How to review this pull request

  • To review, confirm that Gallery component exists and it has design tokens in Emulsify UI Kit

@mariannuar mariannuar self-assigned this Aug 28, 2024
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Aug 28, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 2880d87
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/67536131e4a07500083a21ed
😎 Deploy Preview https://deploy-preview-153--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mariannuar mariannuar added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. labels Sep 17, 2024
@mariannuar mariannuar changed the base branch from main to convert-components-to-sdc September 17, 2024 20:32
@mariannuar mariannuar added 👍 Ready for Review Work is ready for review. and removed 👉 Needs Work Reviewer has requested changes. labels Sep 17, 2024
Base automatically changed from convert-components-to-sdc to main October 23, 2024 16:35
@robherba robherba added the 👁 Review in progress Under review. label Nov 11, 2024
robherba
robherba requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@robherba robherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mari, nice work! Most of the tokens for the gallery component match the Figma design. I just have a couple of small comments:

@robherba robherba added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. 👁 Review in progress Under review. labels Nov 11, 2024
@mariannuar
Copy link
Collaborator Author

@robherba Thank you for your feedback. This is ready for review again :)

@mariannuar mariannuar added 👍 Ready for Review Work is ready for review. and removed 👉 Needs Work Reviewer has requested changes. labels Dec 6, 2024
@mariannuar mariannuar requested a review from robherba December 6, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amazingrando amazingrando Awaiting requested review from amazingrando

@callinmullaney callinmullaney Awaiting requested review from callinmullaney

@robherba robherba Awaiting requested review from robherba

Requested changes must be addressed to merge this pull request.

Assignees

@mariannuar mariannuar

Labels
👍 Ready for Review Work is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @robherba