Added check to not launch popup window with no found link

emvaized · Dec 9, 2024 · 4ca6acf · 4ca6acf
1 parent 1b4babe
commit 4ca6acf
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/content.js b/src/content.js
@@ -72,9 +72,9 @@ function onTrigger(e, type){
         selectedText: window.getSelection().toString().trim(),
         availLeft: window.screen.availLeft, type: type
     }
-    if (type == 'drag' || type == 'shiftClick') {
-        let nodeName, link;
 
+    let nodeName, link;
+    if (type == 'drag' || type == 'shiftClick') {
         /// Handle IMG wrapped in A
         if (t.parentNode && t.parentNode.nodeName == 'A'){
             if (configs.imageWithLinkPreferLink){
@@ -98,13 +98,15 @@ function onTrigger(e, type){
         }
 
         /// Handle IMG with source in sourceset
-        if (nodeName == 'IMG' && !link) {
+        if (nodeName == 'IMG' && !link && t.parentNode && t.parentNode.nodeName == 'PICTURE') {
             const src = t.parentNode.querySelector('source');
             if (src) link = src.getAttribute('srcset');
         }
 
         message['nodeName'] = nodeName;
         message['link'] = link;
     }
-    chrome.runtime.sendMessage(message)
+
+    if (link)
+        chrome.runtime.sendMessage(message)
 }