Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-21446: Updated package dependencies to fix vulnerabilities #107

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

daniel-stoian-lgp
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp commented Mar 31, 2025

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

There were high vulnerabilities

@babel/helpers <7.26.10
Severity: moderate
Babel has inefficient RexExp complexity in generated code with .replace when transpiling named capturing groups - GHSA-968p-4wvh-cqc8
fix available via npm audit fix
node_modules/@babel/helpers

axios <1.8.2
Severity: high
axios Requests Vulnerable To Possible SSRF and Credential Leakage via Absolute URL - GHSA-jr5f-v2jv-69x6
fix available via npm audit fix
node_modules/axios

Resolution

  1. Updated package minor dependencies to fix vulnerabilities
  2. Updated pupeteer and pupeteer-core to latest major version. There were not breaking changes affecting our code https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v24.0.0 https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v24.0.0
  3. Updated react-router-dom to the latest major version. There are no code related breaking changes, but only dependency related ( node >20, react >18, react-dom >18 ) https://reactrouter.com/upgrading/v6

Additional Considerations

I had to modify the source for images in OverallView to a faster source. The previous source took too long to load all images and it caused timeout issues in jest

Links

WRR-21446

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian ([email protected])

Copy link
Contributor

@ion-andrusciac-lgp ion-andrusciac-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hong6316 hong6316 merged commit 234cae6 into develop Apr 8, 2025
daniel-stoian-lgp added a commit that referenced this pull request Apr 8, 2025
* WRQ-8596: Adapt performanceMetrics app for Agate performance tests (#81)

* added performance tests for agate components

* code review fixes

* Adapted performanceMetrics app for Agate test results

* code review fixes

* fixed urls for performanceMetrics

* WRQ-11737: Added performance tests for agate overall view + fixes for other tests (#82)

* avoided unnecessary api call when the theme library is changed in poerformanceMetrics

* Added overallView for Agate
Fixed lint warnings for latest enact/cli
Fixed placeholder images link

* Added tests for agate/overallview
Solved lint warnings

* modified marquee test in order to fix the tests on jenkins

* revert for marquee test

* fix for marquee test

* fix for sandstone/marquee test

* fixed tests for agate/Slider, agate/IncrementSlider, sandstone/Slider and sandstone/Panels

* fixed tests for agate/Panels

* code review fixes

* WRQ-14123: Fixed performanceMetrics when same component is selected once more. Fixed tests where results were saved in the wrong file (#83)

* fixed performanceMetrics when same component is selected once more.
Fixed tests where the tests results were saved in the wrong file

* Fixed performance tests where the metric name was incorrect

* Added missing component options in performance metrics dropdown

* WRQ-16517: Updated dependencies to fix critical vulnerabilities (#84)

* updated dependencies to fix vulnerabilities

* fixed quickguidepanel test view

* WRQ-18593: Changed chart configuration to show all labels and lines (#86)

* updated configuration for chart xAxis

* reverted chart width

* changed xAxis interval and chart size

* fix enact link on sandstone (#87)

* Fix QuickGuidePanel import statement to Panel (#88)

Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])

* WRQ-25865: Updated package dependencies to fix security vulnerabilities (#93)

* Update package dependencies to fix security vulnerabilities

* Updated `react-router-dom` dependency

* WRQ-31596: Fix Critical and High vulnerabilities in agate (#94)

* updated package-lock

* fixed package-lock

* updated package.json

---------

Co-authored-by: Daniel Stoian <[email protected]>

* WRR-1078: Added tests for INP web vital (#92)

* added support for reading interaction to next paint

* Added inp performance tests

* added performance tests for Agate ArcPicker --> IncrementSlider

* Added INP performance tests for agate components

* Added INP Metric for Performance Metrics charts

* import order fix

* removed commented code

* updated readme

* refactored inp tests to download webvitals library instead of using local code

* lint fixes

* adjustments for sandstone inp tests

* adjustments for agate inp tests

* reverse for commented tests

* adjustments for sandstone inp tests

* adjustments for agate inp tests

* adjustments for sandstone inp tests

* adjustments for sandstone inp tests

* adjustments for agate inp tests

* moved url of web vitals library to a global variable

* minor fixes

* updated views and tests for contextualpopup in order to support INP metric. fixed eslint warnings

* pinned web-vitals version

* WRR-2951: Removed tests for FID web-vital (#96)

* Removed tests for FID web-vital

* minor fixes

* WRR-626: Updated puppeteer and wait-on dependencies to latest version (#97)

* upgraded puppeteer to v22

* updated puppeteer to latest version

* updated wait-on to latest version

* Update jsdom-extended.js

* changed ws dependency to 7.5.10

* WRR-10055: Updated package dependencies to fix security vulnerabilities (#101)

* updated dependencies

* updated web-vitals library version

* fixed "'left' is not pressed" warning

* updated performanceMetrics dependencies

---------

Co-authored-by: Daniel Stoian <[email protected]>

* WRR-5490: Add FPS measurement when `translate` scroll to VirtualList (#100)

* added views for virtualList translate

* added separate tests for scrollMode native and translate on keypress and mousewheel

* merged with develop and modified implementation

* refactored previous implementation

* removed native from scrollMode native tests to avoid duplicating charts. native is the default

* removed native from agate tests as well

* review fixes

* fixed url params

* added missing ternary

* added different FPS target for native virtualList vs translate

* testing new method for calculating FPS

* testing requestAnimationFrame method for calculating FPS

* removed duplicated "describe"

* WRR-15939: Updated React to version 19 (#104)

* WRA-21652: Update to React 19 (#89)

* update react to v19@rc

* updated to latest rc version of react19

* updated dependencies to React19

* updated dependencies

* updated agate version

---------

Co-authored-by: adrian-cocoara-lgp <[email protected]>

* WRR-15928: Modified tests to run in production mode and fixed tests for missing metric value (#105)

* converted performance tests to use hashRouter

* migrated performance tests to use production mode

* fix for npm stop script

* adjustments for serve server log information

* fixed tests so undefined metric does not throw error

* WRR-19928: Added performance tests for Limestone components (#106)

* converted performance tests to use hashRouter

* migrated performance tests to use production mode

* fix for npm stop script

* adjustments for serve server log information

* fixed tests so undefined metric does not throw error

* Adapted performance tests to support Limestone

* eslint fixes

* WRR-21446: Updated package dependencies to fix vulnerabilities (#107)

* updated minor dependencies to fix vulnerabilities

* updated puppeteer to latest version

* updated node requirements

* updated react-router-dom

* modified source for images in overall views to a faster source

---------

Co-authored-by: adrian-cocoara-lgp <[email protected]>
Co-authored-by: Juwon Jeong <[email protected]>
Co-authored-by: ion-andrusciac-lgp <[email protected]>
Co-authored-by: paul-beldean-lgp <[email protected]>
Co-authored-by: Stanca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants