Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-3113: Unified CLS and INP tests to use web-vitals library #98

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

daniel-stoian-lgp
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp commented Oct 1, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

CLS and INP had different tests, with duplicate test steps, but different measurement methods

Resolution

Unified CLS and INP tests and both use web-vitals library data

Additional Considerations

Added missing command for filtering tests by component in ReadMe file

Links

WRR-3113

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian ([email protected])

Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants