Improve correctness of ValueIpAddress compares based on family

enclave-networks · Nov 7, 2022 · f40fe80 · f40fe80
1 parent 5931ec4
commit f40fe80
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/Enclave.FastPacket/ValueIpAddress.cs b/src/Enclave.FastPacket/ValueIpAddress.cs
@@ -141,9 +141,18 @@ public override bool Equals(object? obj)
     /// <inheritdoc />
     public bool Equals(ValueIpAddress other)
     {
+        if (_addrFamily != other._addrFamily)
+        {
+            return false;
+        }
+
+        if (_addrFamily == AddressFamily.InterNetwork)
+        {
+            return _addr1 == other._addr1;
+        }
+
         return _addr1 == other._addr1 &&
-               _addr2 == other._addr2 &&
-               _addrFamily == other._addrFamily;
+               _addr2 == other._addr2;
     }
 
     /// <inheritdoc />