Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[docs]: specify units and defaults for ws_* args in docs #2153

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

ryan-mccaffrey
Copy link
Contributor

@ryan-mccaffrey ryan-mccaffrey commented Nov 15, 2023

Summary

Small updates for adding time units and default values for the ws-ping-interval and ws-ping-timeout in documentation

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

uvicorn/main.py Outdated Show resolved Hide resolved
uvicorn/main.py Outdated Show resolved Hide resolved
@Kludex
Copy link
Member

Kludex commented Nov 16, 2023

👍

@Kludex Kludex merged commit dc205af into encode:master Nov 16, 2023
15 checks passed
@Kludex
Copy link
Member

Kludex commented Nov 16, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants