Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client updates to fix bootstrapping and bot-community script for parachain #387

Merged
merged 22 commits into from
Jan 17, 2025

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Jan 17, 2025

Main Changes:

  • Instead of implicitly deciding that a sudo/collective call should be composed based on the absence of the signer arg, we do now explicitly add a CLI arg to decide if the new-community call should be wrapped or not.
  • additionally, we also explicitly check if the transaction should be sent or not via the dry run flag

There were other smaller fixes necessary for the parachain:

  • The tx weight of the parachain is much bigger. I could only batch around 7 add_location calls for a successful proposal. I made this configurable via the -b or --batch-size CLI argument for now, which defaults to 100 so that it is not a breaking change. Note: Interestingly, the error I got for too many locations was misleading:
    • way too many locations: -> TX would exhaust block limit
    • a little bit too much: -> invalid proposal weight (very misleading error)
  • For some reason the faucet amount was off, I could only send around 1 transaction with the reasonable_balance. I just added a factor of 100 for now, and decided to not care about it.

Note: I only fixed the new-community command. add-location should have the same logic in the future with respect to wrapping, batching and dry-running the extrinsic, but I thought this should come with a minor refactoring: #388

I manually tested bootstrapping and the bot-community against the parachain, and it works 🥳.

@clangenb clangenb changed the title Client updates for parachain Client updates to fix bootstrapping and bot-community script for parachain Jan 17, 2025
@clangenb clangenb requested a review from brenzi January 17, 2025 11:27
.takes_value(true)
.required(false)
.default_value("none")
.value_name("none|sudo|collective")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a nice solution

Copy link
Member

@brenzi brenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clangenb clangenb merged commit 23919c9 into master Jan 17, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants