-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client updates to fix bootstrapping and bot-community script for parachain #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new community call
…haust block limits
clangenb
changed the title
Client updates for parachain
Client updates to fix bootstrapping and bot-community script for parachain
Jan 17, 2025
brenzi
reviewed
Jan 17, 2025
.takes_value(true) | ||
.required(false) | ||
.default_value("none") | ||
.value_name("none|sudo|collective") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a nice solution
brenzi
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes:
There were other smaller fixes necessary for the parachain:
-b
or--batch-size
CLI argument for now, which defaults to 100 so that it is not a breaking change. Note: Interestingly, the error I got for too many locations was misleading:reasonable_balance
. I just added a factor of 100 for now, and decided to not care about it.Note: I only fixed the
new-community
command.add-location
should have the same logic in the future with respect to wrapping, batching and dry-running the extrinsic, but I thought this should come with a minor refactoring: #388I manually tested bootstrapping and the bot-community against the parachain, and it works 🥳.