Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorize carriers #145

Closed
wants to merge 13 commits into from
Closed

Categorize carriers #145

wants to merge 13 commits into from

Conversation

TheGiraffe3
Copy link

Summary

Changed all carriers into the new "Heavy Carrier" and "Light Carrier" categories.

@Zitchas Zitchas added the Content (data) The information that the game uses to make everything label Nov 24, 2024
@Zitchas
Copy link
Member

Zitchas commented Nov 28, 2024

Sorry it has taken a while to get to this:

  • What criteria do you use to determine which ship goes into which category?
  • What are the cutoffs? For instance, the Bactrian has more fighter bays than both the Aerie and the Nest and only one less than the Roost.
  • What does this do to Shipyard sets? I suspect it results in several shipyard categories only have one or maybe two ships in them.

@TheGiraffe3
Copy link
Author

I used the criteria from the Carrier Categories pull request to upstream.
All of the categories have at least three ships in them.

@TheGiraffe3
Copy link
Author

So see #8843 for the background on this.

@TheGiraffe3 TheGiraffe3 deleted the carrier-categories branch January 22, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Content (data) The information that the game uses to make everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheGiraffe3 @Zitchas