Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metainfo: Use Endless Key brand #16

Merged
merged 2 commits into from
Sep 1, 2023
Merged

metainfo: Use Endless Key brand #16

merged 2 commits into from
Sep 1, 2023

Conversation

starnight
Copy link
Contributor

Fixes: #15

@starnight starnight self-assigned this Aug 29, 2023
@starnight starnight force-pushed the update-metainfo-with-endlesskey branch from b72066d to 1bc0d0c Compare August 30, 2023 03:44
dbnicholson
dbnicholson approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to start. This will get more polish in #20.

data/metainfo/org.learningequality.Kolibri.metainfo.xml.in.in Outdated Show resolved Hide resolved
dbnicholson
dbnicholson requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this now has a conflict with upstream's metainfo since 2.3.3 was released. Can we either rename this to org.endlessos.Key.metainfo.xml now or empty out <releases>?

@starnight starnight force-pushed the update-metainfo-with-endlesskey branch from 1bc0d0c to aba2c80 Compare September 1, 2023 06:31
@starnight
Copy link
Contributor Author

How about take both: Rename metainfo and empty out <releases>

@starnight starnight marked this pull request as draft September 1, 2023 07:06
@starnight starnight force-pushed the update-metainfo-with-endlesskey branch from aba2c80 to a288529 Compare September 1, 2023 07:08
@starnight
Copy link
Contributor Author

Uh! The metainfo needs <release> node. Otherwise, the test will be failed:

Running tests
[0/1] Running all tests.
1/3 Validate desktop file                      OK              0.01s
2/3 Validate metainfo file                     FAIL            0.02s   exit status 1
>>> MALLOC_PERTURB_=141 /usr/bin/appstream-util validate --nonet data/metainfo/org.endlessos.Key.Devel.metainfo.xml
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀  ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stdout:
data/metainfo/org.endlessos.Key.Devel.metainfo.xml: FAILED:
• tag-missing           : <release> required
stderr:
Validation of files failed

@starnight starnight force-pushed the update-metainfo-with-endlesskey branch 3 times, most recently from baf24cf to f69e177 Compare September 1, 2023 08:19
@starnight
metainfo: Use Endless Key brand
48653ba 
Modify metainfo with Endless Key brand as the new metainfo:
org.endlessos.Key.metainfo.xml.in.in

Fixes: #15
@starnight
Use "Endless Key" as the name of the desktop entry
5af6dd6 
Fixes: #15
@starnight starnight force-pushed the update-metainfo-with-endlesskey branch from f69e177 to 5af6dd6 Compare September 1, 2023 08:34
@starnight starnight marked this pull request as ready for review September 1, 2023 08:46
@starnight
Copy link
Contributor Author

To let Adapt the store listings metainfo for the Endless Key flatpak go smoother, I merge this PR.

@starnight starnight merged commit 7f5d676 into main Sep 1, 2023
2 checks passed
@starnight starnight deleted the update-metainfo-with-endlesskey branch September 1, 2023 09:27
@starnight
Copy link
Contributor Author

Verified with #15 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwithnall pwithnall pwithnall left review comments

@dbnicholson dbnicholson dbnicholson requested changes

@erikos erikos Awaiting requested review from erikos

@jofilizola jofilizola Awaiting requested review from jofilizola

Assignees

@starnight starnight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have Endless Key flavor metainfo.xml
3 participants
@starnight @pwithnall @dbnicholson