Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length (number) prop to whitelist AsyncGenerator and AsyncFunctionPrototype #1511

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Mar 15, 2023

Fix: #660
Fix: LavaMoat/docs#16

cc @naugtur

nb: will stick to 1 commit in future


Before

Screenshot 2023-03-15 at 14 42 08

After

Screenshot 2023-03-15 at 14 43 12


looks like checks CI / test-async-hooks failing on GHA setup-node matrix after adding docs (code comments) :suspect:
so hopefully we only need to re-trigger the checks (i don't have permish from my fork)

Run actions/setup-node@v1
  with:
    node-version: 16.1
    always-auth: false
Premature close
Waiting 14 seconds before trying again
Premature close
Waiting 1[2](https://github.com/endojs/endo/actions/runs/4425617947/jobs/7760903288#step:3:2) seconds before trying again
Error: Premature close

edit: rebase + force-push worked ✅

@leotm leotm marked this pull request as ready for review March 15, 2023 11:13
@leotm leotm force-pushed the leotm-AsyncGenerator-AsyncFunctionPrototype-length branch from 5b070e9 to acaf5e9 Compare March 15, 2023 11:46
@leotm leotm changed the title Add length (number) prop to whitelist AsyncGenerator and AsyncFunctionPrototype Add length _number_ prop to whitelist AsyncGenerator and AsyncFunctionPrototype Mar 15, 2023
@leotm leotm changed the title Add length _number_ prop to whitelist AsyncGenerator and AsyncFunctionPrototype Add length (number) prop to whitelist AsyncGenerator and AsyncFunctionPrototype Mar 15, 2023
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erights erights merged commit c08b15b into endojs:master Mar 15, 2023
@leotm leotm deleted the leotm-AsyncGenerator-AsyncFunctionPrototype-length branch March 15, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants