Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compartment-mapper): Fix path for language for extension test #2640

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix(compartment-mapper): Fix path for language for extension test #2640

merged 1 commit into from
Nov 21, 2024

Conversation

kriskowal
Copy link
Member

This is a small typo in a test that was producing a different error than the expected variety.

boneskull
boneskull approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like something that benefits from code review, but have another approval anyway

@kriskowal kriskowal merged commit 7da1c44 into master Nov 21, 2024
15 checks passed
@kriskowal kriskowal deleted the kriskowal-fix-cm-lfe-test branch November 21, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneskull boneskull boneskull approved these changes

@naugtur naugtur naugtur approved these changes

@mhofman mhofman mhofman approved these changes

@erights erights Awaiting requested review from erights

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kriskowal @mhofman @naugtur @boneskull