fix(compartment-mapper): Dev implied by development condition only for entry package #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-fix-cm-lfe-test
branch
from
f561656
to
ec1380a
Compare
kriskowal
force-pushed
the
kriskowal-fix-dev-condition-implication
branch
from
955846b
to
1024859
Compare
…encies for entry package
kriskowal
force-pushed
the
kriskowal-fix-cm-lfe-test
branch
from
ec1380a
to
99a1cb5
Compare
kriskowal
force-pushed
the
kriskowal-fix-dev-condition-implication
branch
from
1024859
to
b7d7b23
Compare
boneskull
approved these changes
Nov 21, 2024
| const graph = await graphPackages( | ||
| maybeRead, | ||
| canonical, | ||
| packageLocation, | ||
| conditions, | ||
| packageDescriptor, | ||
| dev, | ||
| dev || (conditions && conditions.has('development')), |
There was a problem hiding this comment.
conditions is never falsy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this bug while reviewing Compartment Mapper: I’ve deprecated the
devoption ofmapNodeModulesin favor ofdevelopmentin theconditionsset option, since generally one should want both behaviors for development mode, so one should imply the other. However, the way this is implemented causesdevDependenciesto be linked for every package in the presence of thedevelopmentcondition, and should only be in the entry package.