Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding IssueOptionsDto.proofPurpose #151

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

artursudnik
Copy link
Member

@artursudnik artursudnik commented Oct 26, 2022

This PR:

  • adds IssueOptionsDto.proofPurpose field that is out of specs, but required by the W3CCG test suite
  • fixes a bug where VerifyOptionsDto.proofPurpose enum is not validated

@artursudnik artursudnik self-assigned this Oct 26, 2022
@artursudnik artursudnik requested a review from jrhender October 26, 2022 09:52
@artursudnik artursudnik changed the title fix: adding issue options dto proof purpose fix: adding IssueOptionsDto.proofPurpose Oct 26, 2022
@jrhender
Copy link
Collaborator

I think we hold this PR until the get some clarity on this question w3c-ccg/vc-api-test-suite#23
Does this make sense to you @artursudnik ?

@artursudnik
Copy link
Member Author

Yes, it should be put on hold until we decide if it is applicable. I opened it not to forget about this potential fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants