Adds enhanced ✨ attribute so we know when to replace children in our … #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brian ran into an issue when using our Custom Element base class for strictly client side purposes. We currently don't expand your Custom Element with the template contents if it has children already since we assume it's been SSR'd.
In this case it had authored children to be replaced but we didn't expand it since this is only in the browser.
The only sure fire way I could come up with to know for sure that we expanded the custom element server side is to add an attribute
enhanced.This has a boolean that allows you to omit this if you don't want it, but I think people will.
This also sneaks in looking for a render function on the prototype of an element passed to Enhance SSR for the class only version of SSR.