Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds minimal light / dark theme support with accent color #32

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

kristoferjoseph
Copy link
Contributor

One thing I would like feedback on is the removal of the default error, info, success, etc. theme colors.

No one seemed to be using them and they are easy to add back ( on prop in the config.json file ) so I figured it was safe to remove but am open to putting them back if anyone has big feels about it.

Copy link
Member

@colepeters colepeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! One question, one suggestion, but looks great!

config.json Show resolved Hide resolved
size.mjs Outdated Show resolved Hide resolved
theme-color.mjs Outdated Show resolved Hide resolved
theme-color.mjs Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
config.json Show resolved Hide resolved
@kristoferjoseph kristoferjoseph merged commit 8803fb2 into main Oct 6, 2023
2 checks passed
@kristoferjoseph kristoferjoseph deleted the light-dark-theme branch October 6, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants