Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opt outs for theme & color #44

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Add opt outs for theme & color #44

merged 5 commits into from
Mar 25, 2024

Conversation

colepeters
Copy link
Member

Allows users to opt out of generating theme and color styles

@colepeters colepeters self-assigned this Mar 21, 2024
@colepeters colepeters linked an issue Mar 21, 2024 that may be closed by this pull request
Allow opt out of theming #42
Closed
kristoferjoseph
kristoferjoseph requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@kristoferjoseph kristoferjoseph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like theme: false does what I expect.
color: false is the same as not supplying any spot colors. Is that the desired outcome?
What should the additions to the README be?

kristoferjoseph
kristoferjoseph approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@kristoferjoseph kristoferjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is easier to explain. Thanks for making those changes.

@colepeters colepeters merged commit 20eb752 into main Mar 25, 2024
2 checks passed
@colepeters colepeters deleted the optout-theme branch March 25, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferjoseph kristoferjoseph kristoferjoseph approved these changes

Assignees

@colepeters colepeters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow opt out of theming
2 participants
@colepeters @kristoferjoseph