Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dependabot and Github Workflows to format, lint, build and test the crate #128

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

pentamassiv
Copy link
Collaborator

In order to reduce the effort it takes to maintain this library, I added Dependabot and Github Workflows. Dependabot will automatically open a PR if a dependency or one of the used Github Actions is out of date. The Github Workflows will ensure that the code

  • is properly formatted
  • there are no clippy lints
  • the library builds
  • the examples build
  • all tests are successful

This is done for all supported platforms (linux, macos, windows) and for three Rust versions. The Rust versions are:

The workflows can be manually started and they automatically run if a PR was raised

- uses: actions/checkout@v3
- uses: ./.github/actions/install_deps
- name: Set up Rust
uses: dtolnay/rust-toolchain@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have much experience with github workflows. How "settled" is dtolnay/rust-toolchain i only read about actions-rs/toolchain being abandoned and the community is trying to make/find a replacement. Is that it? In any case, even if it changes to a different repository later on we could change that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure about that either. Here is the relevant issue: actions-rs/toolchain#216. A number of projects switched to it and I also noticed that BurntSushi switched to it for the rust-lang/regex repo (PR). I believe it is a popular Workflow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just go ahead – we can change it later if its necessary, we don't maneuver our self into a corner either way. I just wanted to know your opinion about it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sure

@pentamassiv pentamassiv merged commit 432af1d into enigo-rs:master Jan 23, 2023
@pentamassiv pentamassiv deleted the gh_actions branch January 23, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants