Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tests #14

Closed
wants to merge 27 commits into from
Closed

[WIP] Tests #14

wants to merge 27 commits into from

Conversation

mihaiberq
Copy link
Contributor

@mihaiberq mihaiberq commented Nov 28, 2017

  • Add tests to all parse methods
    • Make sure parse methods can handle every insight, workout, course and topic currently on the master branch
    • Make sure parse methods can handle the standards branch
  • Add tests to all render methods
    • Make sure the render methods accurately reproduce a parsed file (no data loss, file can be re-parsed)

@lizTheDeveloper
Copy link
Contributor

Added an outline for the insight tests, completing all the tests that say xit is sufficient to resolve issue #30
@milesflo or @loopiezlol can you jump on this, figured it might help to get ya started.

@milesflo milesflo self-assigned this Feb 19, 2018
@lizTheDeveloper lizTheDeveloper changed the base branch from master to v1 February 24, 2018 01:04
@lizTheDeveloper
Copy link
Contributor

@milesflo take a look at the outline here: 32d4b09
That's the format I'm after - it's ok to use Jest, you should be able to translate the tests over simply

@lizTheDeveloper
Copy link
Contributor

@mihaiberq and @milesflo I would like you guys to take a Friday one day and try to get this branch and the other tests branch working. Much of the interface has changed, as well as the functionality, so ask @loopiezlol how to proceed- make a plan together (just write a checklist of what methods you need to test and a note about the cases to test for each of them) and get him to review it, then write the tests and ask him to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants