Skip to content

Commit

Permalink
Merge branch 'main' into socket-optimize
Browse files Browse the repository at this point in the history
  • Loading branch information
talentlessguy authored Oct 27, 2024
2 parents 5a123f1 + 0332869 commit bc30075
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/pages-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,16 @@ jobs:
SITEMAP_GRAPH_KEY: ${{ secrets.SITEMAP_GRAPH_KEY }}

- name: Publish
uses: cloudflare/pages-action@v1
uses: cloudflare/wrangler-action@v3
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
projectName: ens-app-v3
directory: out
gitHubToken: ${{ secrets.GITHUB_TOKEN }}
wranglerVersion: '3'
wranglerVersion: 'v3.57.1'
command: pages deploy --project-name=ens-app-v3
secrets: |
GITHUB_TOKEN
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Submit sitemap
if: ${{ github.ref == 'refs/heads/main' }}
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ have developed a design system in order to ensure consistent styling across the
Pages folder has basic route layout and basic react needed for rendering pages. These
files should be kept relatively simple

Components that pages consume are kept in the components folder. This folder has a strucutre
that mimicks the strucutre of the pages folder. If a component is only used on a specific page
Components that pages consume are kept in the components folder. This folder has a structure
that mimics the structure of the pages folder. If a component is only used on a specific page
then it goes into the corresponding folder in the components folder.

If a component is used across multiple pages and other components,
Expand Down Expand Up @@ -254,7 +254,7 @@ Once exited, you can commit the data to your branch. You do not need to run a se

#### Stateless vs Stateful

Our e2e tests are split into two categories, stateless and stateful. Stateless test use the development environment, are faster, and is the general recommended way to write integration tests. Occasionally, you may need to test a feature that requires an external api or service. In this case, you can use the stateful tests. These tests are slower,
Our e2e tests are split into two categories, stateless and stateful. Stateless test use the development environment, are faster, and is the general recommended way to write integration tests. Occasionally, you may need to test a feature that requires an external API or service. In this case, you can use the stateful tests. These tests are slower,

#### Running the tests

Expand Down
2 changes: 1 addition & 1 deletion src/pages/legacyfavourites.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default function Page() {
name,
network: chainId,
hasOtherItems: false,
expiryDate: { date: expiry, value: expiry.getTime() },
expiryDate: { date: expiry, value: expiry?.getTime() },
}}
/>
))}
Expand Down
4 changes: 3 additions & 1 deletion wrangler.toml
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
# compatibility_flags = [ "streams_enable_constructors" ] // Prevents wrangle from launching
# compatibility_flags = [ "streams_enable_constructors" ] // Prevents wrangle from launching
name = "ens-app-v3"
pages_build_output_dir = "out"

0 comments on commit bc30075

Please sign in to comment.