Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ The App is hosted on cloudflare and IPFS

#### [Ens.js](https://github.com/ensdomains/ensjs-v3)

Much of the logic around interacting with the ENS contracts has been extraced into this
Much of the logic around interacting with the ENS contracts has been extracted into this
library. This is mostly so that we can help to make the experience of interacting with
ENS as simple as possible for other developers.

Expand Down
2 changes: 1 addition & 1 deletion playwright/fixtures/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class Login {
/**
* TEMP FIX
* A bug in rainbow kit needs time to load the provider. Could be fixed in version 1.0.4
* Also throws eror with walletconnect if not enough time has passed.
* Also throws error with walletconnect if not enough time has passed.
*/
}

Expand Down
2 changes: 1 addition & 1 deletion playwright/fixtures/makeName/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

## Known issues and development notes

- Nonce management is controlled by the default **nonceManager** when the accounts are created. This is required in order to make parrallel transactions work correctly.
- Nonce management is controlled by the default **nonceManager** when the accounts are created. This is required in order to make parallel transactions work correctly.
- When sending transaction, you will need to use the lower level **viem** functions **walletClient.prepareTransactionRequest** and **walletClient.senTransaction** so that the nonceManager will work correctly.
- When using prepareTransactionRequest, you will need to add a custom **gas** value. Without it, the function will throw an error because it will not be able to estimate the gas for a transaction where the nonce value is not sequential to the last transaction mined.