Introduce VC spec #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucemans
force-pushed
the
ensip/vc
branch
9 times, most recently
from
87d1a02 to
29c5e29
Compare
Deploying ensips with
|
| Latest commit: |
212f74a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd9166e8.ensips.pages.dev |
| Branch Preview URL: | https://ensip-vc.ensips.pages.dev |
lucemans
force-pushed
the
ensip/vc
branch
9 times, most recently
from
05f1d5a to
f9bb90e
Compare
lucemans
force-pushed
the
ensip/vc
branch
2 times, most recently
from
9e3e84b to
dae0ddd
Compare
Ghadi8
reviewed
Jan 7, 2025
| "type": ["VerifiableCredential"], | ||
| "issuanceDate": "2024-05-21T00:00:00Z", | ||
| "credentialSubject": { | ||
| "id": "did:ens:luc.eth", // the subject's ens name |
There was a problem hiding this comment.
it might be useful to add the address here as well, as the ens owner can change and render the credential invalid. so it might look something like that:
"did:ens:luc.eth#0x225f137127d9067788314bc7fcc1f36746a3c3B5"
|
|
||
| Note the requirement for `id` to be `did:ens:luc.eth` in order to prevent credential spoofing. | ||
|
|
||
| ```json |
There was a problem hiding this comment.
wouldn't the issuer and Proof be needed here as well?
We also worked on a fix for the ens did resolver library and are currently using it at JustaName. We will open a PR with the fix, and potentially publish the lib if needed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the verifiable Credential Specification.
This specification allows for W3C Verifiable Credentials to be stored inside ENS profiles
PS; This PR is also used for testing the ensip flow