Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting abi and add tests #161

Merged
merged 8 commits into from
Jan 21, 2024
Merged

fix setting abi and add tests #161

merged 8 commits into from
Jan 21, 2024

Conversation

storywithoutend
Copy link
Contributor

Allow deleting an Abi content type by passing null into data

TateB
TateB requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@TateB TateB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, make sure to merge from main as well

packages/ensjs/src/functions/wallet/setAbiRecord.test.ts Outdated Show resolved Hide resolved
packages/ensjs/src/utils/encoders/encodeAbi.ts Outdated Show resolved Hide resolved
packages/ensjs/src/utils/encoders/encodeAbi.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@TateB TateB merged commit 246fc00 into main Jan 21, 2024
3 checks passed
@LeonmanRolls LeonmanRolls deleted the fix/delete-abi-with-setRecords branch January 25, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TateB TateB TateB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@storywithoutend @TateB @sugh01