Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getDnsOffchainData func for gasless dns #169

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

TateB
Copy link
Collaborator

@TateB TateB commented Jan 31, 2024

changes:

  • added getDnsTxtRecords for fetching dns txt records
    • this is under the utils/ namespace because it's more of an internal func
  • using getDnsTxtRecords in getDnsOwner
  • using strict pattern from resolver methods in getDnsOwner
  • added getDnsOffchainData for fetching gasless dns data. it returns resolverAddress/extraData or null.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

55.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@TateB TateB merged commit 1c7c1ca into main Jan 31, 2024
2 of 3 checks passed
@LeonmanRolls LeonmanRolls deleted the feat/offchain-dns-fetch branch February 1, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants