Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a way for callers to get CCIP requests #7

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Introduce a way for callers to get CCIP requests #7

merged 4 commits into from
Dec 6, 2023

Conversation

Antony1060
Copy link
Contributor

This PR adds a method to CCIPReadMiddleware that will return all CCIP requests back to the caller.

@Antony1060 Antony1060 marked this pull request as ready for review November 24, 2023 14:07
lucemans
lucemans approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antony1060 Antony1060 mentioned this pull request Nov 26, 2023
Merged
@mdtanrikulu
Copy link
Contributor

where exactly these requests provided back to the caller? I see a vector created in ccip_call method and it returns both result and requests as tuple. But then call just returns the result (by ?.0). So will ccip_call also be callable by the user?

@Antony1060
Copy link
Contributor Author

Antony1060 commented Dec 1, 2023 •
edited
Loading

Yeah, there's now a call_ccip method that does just that. call is left with its original signature so it doesn't break previous versions.

@mdtanrikulu
Copy link
Contributor

Yeah, there's now a call_ccip method that does just that. call is left with its original signature so it doesn't break previous versions.

It would be super helpful to have a lil comment explaining that on top of call_ccip, other than that lgtm.

@Antony1060
Copy link
Contributor Author

You're right, I added a comment although not sure if I worded it correctly or if there are any Rust standards for them.

@lucemans lucemans merged commit e4a1adb into ensdomains:main Dec 6, 2023
1 check passed
@lucemans lucemans deleted the feat/caller-ccip-requests branch December 6, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucemans lucemans lucemans approved these changes

@mdtanrikulu mdtanrikulu mdtanrikulu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Antony1060 @mdtanrikulu @lucemans