Multicall CCIP-read gateway #22
Conversation
| @@ -0,0 +1,127 @@ | |||
| import { formatsByCoinType } from '@ensdomains/address-encoder'; | |||
There was a problem hiding this comment.
Can't all of this be replaced by a simple call to Ethers to resolve the name now?
| yarn start --private-key 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 --data test.eth.json | ||
| ``` | ||
|
|
||
| `private-key` should be an Ethereum private key that will be used to sign messages. You should configure your resolver contract to expect messages to be signed using the corresponding address. |
There was a problem hiding this comment.
Why is the batch gateway signing messages?
| import { Command } from 'commander'; | ||
| const program = new Command(); |
There was a problem hiding this comment.
| import { Command } from 'commander'; | |
| const program = new Command(); | |
| import { Command } from 'commander'; | |
| const program = new Command(); |
| @@ -0,0 +1,76 @@ | |||
| import { Database } from './server'; | |||
There was a problem hiding this comment.
This file should be unnecessary for the batch gateway.
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should be unnecessary for the batch gateway.
| const callData = d.callData; | ||
| const gatewayUrl = url | ||
| .replace('{sender}', sender) | ||
| .replace('{data}', callData); |
There was a problem hiding this comment.
If {data} isn't present, this should send a POST request, per EIP 3668.
| @@ -0,0 +1,18 @@ | |||
| { | |||
There was a problem hiding this comment.
This shouldn't be necessary for the batch gateway.
| @@ -0,0 +1 @@ | |||
| export const ETH_COIN_TYPE = 60; | |||
There was a problem hiding this comment.
This shouldn't be necessary for the batch gateway.
| } | ||
| } | ||
|
|
||
| const TEST_DB = { |
There was a problem hiding this comment.
None of this should be needed.
| ); | ||
| } | ||
|
|
||
| describe('End to end test', () => { |
There was a problem hiding this comment.
This looks like it's testing the resolver gateway?
|
Deprecated. The new PR is ensdomains/batch-gateway#1 |
Resolve #17